feat!: set the mode directly in the client #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thaisdeboisfosse <thais.de-boisfosse@owkin.com>
4 tasks
Signed-off-by: thaisdeboisfosse <thais.de-boisfosse@owkin.com>
Esadruhn
requested review from
jmorel,
inelgnu,
samlesu,
Fabien-GELUS and
louishulot
as code owners
|
/e2e --refs substrafl=local_mode_client,substra-tests=local_mode_client --mode standalone --tests sdk,substrafl |
|
The error is |
|
/e2e --refs substrafl=local_mode_client,substra-tests=local_mode_client --mode standalone --tests sdk,substrafl |
|
fixed the substra tests |
|
/e2e --refs substrafl=local_mode_client,substra-tests=local_mode_client --mode standalone --tests sdk,substrafl |
|
End to end tests: ✔️ SUCCESS Awesome sauce! |
louishulot
approved these changes
Sep 21, 2022
| if debug: | ||
| # Hybrid mode: the local backend also connects to | ||
| # a remote backend in read-only mode. | ||
| if backend_type in [schemas.BackendType.LOCAL_DOCKER, schemas.BackendType.LOCAL_SUBPROCESS]: |
There was a problem hiding this comment.
Suggested change
| if backend_type in [schemas.BackendType.LOCAL_DOCKER, schemas.BackendType.LOCAL_SUBPROCESS]: | |
| elif backend_type in [schemas.BackendType.LOCAL_DOCKER, schemas.BackendType.LOCAL_SUBPROCESS]: |
There was a problem hiding this comment.
we do not need a elif since there is a return statement in the if above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PRs
#287
Substra/substrafl#19
Substra/substra-tests#210
Substra/substra-documentation#178
Context and user need
In local mode, we can choose between docker model and subprocess mode. This choice is done by the user by specifying an environment variable.
Specifying an environment variable can be difficult and annoying for the user, especially for user without a lof of experience with the terminal.
Functional spec
Specify the local mode with: Client(mode=["REMOTE", "LOCAL_DOCKER", "LOCAL_SUBPROCESS"])
default value: remote
Technical spec:
right now there is a variable env, change how it is passed
use an enum
update the tests:
substra
connectlib
connect-tests
update the examples:
connect-documentation
update the CI
Tests: parametrize the spawner type as a fixture
Update the makefile:
have test fast and slow
keep the same general commands (ie be able to launch the PR tests, the tests on main, and additional commands to keep the dev easy (eg run only fast subprocess test))
Acceptance criteria:
User can specify the local mode to use without having to use environment variables
Notes
Please check if the PR fulfills these requirements